Merged
Conversation
nicksieger
approved these changes
Mar 4, 2025
Contributor
Author
|
Thanks @nicksieger . I should have marked this PR as draft. We first need to test it, but I can't see the settings if GH actions are enabled, or what else is preventing the new workflow file from running. 🤔 |
Member
|
I don't think you can test it until it's merged? Maybe we set it up to be a |
Contributor
Author
|
This other PR tilt-dev/tilt.build#1165 for the other websites works even before merging. That's why I was hoping. 😄 |
Member
|
ya, i don't understand why the workflow didn't run |
nicks
force-pushed
the
gh_deploy_on_s3
branch
2 times, most recently
from
fd57063 to
1b9e817
Compare
Member
|
lol there was a typo |
nicks
force-pushed
the
gh_deploy_on_s3
branch
2 times, most recently
from
bc5ed02 to
0c3db44
Compare
Signed-off-by: Stefan Scherer <stefan.scherer@docker.com> Signed-off-by: Nick Santos <nick.santos@docker.com>
Member
|
wooo it works - https://api2.tilt.dev/ |
Member
|
(i'll let @StefanScherer merge if there are any additional changes you wanted to make) |
Signed-off-by: Stefan Scherer <scherer_stefan@icloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.